track adt variant and field names do not conflict #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intent of this change is to add a check for adts that enum variant names are unique, and that struct and enum field names are unique (within a given enum variant).
lcnr
reviewed
Jun 24, 2024
nikomatsakis
requested changes
Jun 24, 2024
nikomatsakis
approved these changes
Jul 1, 2024
nikomatsakis
requested changes
Jul 1, 2024
nikomatsakis
approved these changes
Jul 1, 2024
nikomatsakis
requested changes
Jul 1, 2024
src/test/mod.rs
Outdated
| } | ||
| ] | ||
|
|
||
| [ /* TODO */ ] |
There was a problem hiding this comment.
add suggested messages in here
There was a problem hiding this comment.
Ah, I copied this from pre-existing tests in this file, so I had no idea what to put here, but scrolled down and found some other examples. This is supposed to be some summary of what's wrong with the code?
There was a problem hiding this comment.
ah wait, maybe instead it's some relevant substring in the error output that shouldn't change even when you update the expect output? (guessing from assert_err! naming that tt must_have and the other expect)
src/test/mod.rs
Outdated
| } | ||
| ] | ||
|
|
||
| [ /* TODO */ ] |
nikomatsakis
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of this change is to add a check for adts that enum variant names are unique, and that struct and enum field names are unique (within a given enum variant).